-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(navbar): various navbar spacing tweaks #2855
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
282ac49
to
6ce188d
Compare
packages/components/navbar/src/NavbarSwitcher/NavbarSwitcherSkeleton.tsx
Show resolved
Hide resolved
I updated the PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking care of this 👍
* feat(navbar): various navbar spacing tweaks * fix: add box-sizing * fix: change switcher skeleton radius * fix: use `SkeletonText` instead of `SkeletonDisplayText` * fix: do not wrap `SwitcherSkeleton` in `Switcher` * chore: release new navbar version
Purpose of PR
This PR makes the navbar more consistent, also changes the spacing/sizes to be closer to the designs.
General:
Regular navbar
Loading
Mobile menu button:
It's best to check chromatic for the detailed changes
PR Checklist
readme.md
file(s)